Partially replace the use of eth-lib #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://web3-js-pr-4390.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c57t801t9dse23vff9t0. |
|
This pull request introduces 1 alert when merging dfa23a0 into 977f0f9 - view on LGTM.com new alerts:
|
luu-alex
reviewed
Sep 26, 2021
spacesailor24
commented
Sep 26, 2021
luu-alex
approved these changes
Sep 26, 2021
Pull Request Test Coverage Report for Build 1274222255
💛 - Coveralls |
spacesailor24
added a commit
that referenced
this pull request
Sep 26, 2021
* Replace usage of eth-lib with etheruemjs-util for hashing in web3-eth-accounts * Replace usafe of eth-lib with etheruemjs-util for hashing in web3-utils * Update web3.utils tests * Add etheruemjs-util as dev dependency for use in tests * Update CHANGELOG * Fix typo in packages/web3-utils/src/utils.js
Closed
This was referenced Nov 24, 2021
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're making an effort to replace the usage of one-off libraries with official @ethereumjs libraries, and we're doing it one library at a time to reduce the chance of breaking changes
In this PR we're partially replacing the use of eth-lib, by updating the hashing methods, but keeping the methods used for account generation and signatures. We'll need to have further discussion around these since there's no replacement provided by
@ethereumjs